DD-WRT Root exploit posted today

Post new topic   Reply to topic    DD-WRT Forum Index -> Broadcom SoC based Hardware
Goto page Previous  1, 2, 3 ... 10, 11, 12, 13, 14, 15  Next
Author Message
kcrimson
DD-WRT Novice


Joined: 02 May 2009
Posts: 27

PostPosted: Thu Jul 23, 2009 20:17    Post subject: Reply with quote
I've flashed the "edge" DD-WRT router to EKO's 12548 build on my home network - do I need to flash any additional DD-WRT routers on the network that are running in RB or CB mode behind that router?

In other words - can this exploit be performed on a router that's acting as a repeater-bridge or client-bridge?
Sponsor
chris
Site Admin


Joined: 06 Jun 2006
Posts: 101
Location: Germany, Bensheim

PostPosted: Thu Jul 23, 2009 20:18    Post subject: Reply with quote
Hi,

any router that can be accessed via ip is vulnerable. So if you have 10 routers, update 10 routers.

_________________
NewMedia-NET GmbH
Christian Scheele (CEO)
http://www.dd-wrt.com
phuzi0n
DD-WRT Guru


Joined: 10 Oct 2006
Posts: 10141

PostPosted: Thu Jul 23, 2009 20:48    Post subject: Reply with quote
gat3way wrote:
Now about the cgi-bin vulnerability. Some people say it is not possible as a result of a CSRF attack because the backslash (in my example) becomes url-encoded. Well in a way they are right, the backslash gets urlencoded. OTOH (sorry for being rude) - guys you need to read some "bash for dummies" book and if you already have, then you have no imagination at all. What about spawning a shell at port tcp/11111 by using [removed] for example? Yeah, no backslash there and it works.

I think I made it rather clear that I was only talking about the example link and that it was likely possible by other means. No need to spell out a method that does work without the backslash. Posting clear examples to exploit a vulnerability that is already patched serves nothing more than to be malicious, you already made your point clear that the vulnerability exists and it has been patched.

_________________
Read the forum announcements thoroughly! Be cautious if you're inexperienced.
Available for paid consulting. (Don't PM about complicated setups otherwise)
Looking for bricks and spare routers to expand my collection. (not interested in G spec models)
OB1
DD-WRT Novice


Joined: 22 Jul 2009
Posts: 25

PostPosted: Thu Jul 23, 2009 21:16    Post subject: Reply with quote
crashfly wrote:
No. Because the same thing happens to many people's computers in a day. Eventually, they figure out they have a virus and the get someone to fix the problem. Those who actually *keep* up with their router's firmware, will upgrade and be safe. Enough said.

If you think there should be a *major* announcement, then donate to the cause. Give money to DD-WRT, and put out the word that everyone needs to update. That is all you can really do.


Uh they "figure out they have a virus" ?!?

How ? Why ?

If someone r00ted their router the LAST thing he would do is "alerting" the victims; come on, get REAL, we aren't living in the eighties
gat3way
DD-WRT Novice


Joined: 23 Jul 2009
Posts: 4

PostPosted: Thu Jul 23, 2009 21:17    Post subject: Reply with quote
Quote:
Posting clear examples to exploit a vulnerability that is already patched serves nothing more than to be malicious, you already made your point clear that the vulnerability exists and it has been patched.


I cannot agree with your definition of "malicious". Malicious would be setting up your own router-based botnet for example, or selling the exploit to some anonymous Russian over the net - that IMO would be malicious and vile indeed. Hiding information, even information concerning vulnerabilities does no good. Anyway, that's just my personal viewpoint.
OB1
DD-WRT Novice


Joined: 22 Jul 2009
Posts: 25

PostPosted: Thu Jul 23, 2009 21:21    Post subject: Reply with quote
gat3way wrote:
Hello,

all. What about spawning a shell at port tcp/11111 by using [removed:phuzi0n] for example? Yeah, no backslash there and it works.

And sorry for the mess Smile


ROFL...that's something I tried to enforce, but apparently ... I did hit deaf ears :P

anyways... that isn't "sorry for the mess", the right one is "thanks for all that fish" ;-D

/ME running to hide somewhere <g>

[edit]

Uh.. and ... I forgot, did you notice we're all
"novices" here <g> ... how comes <vBeg>
phuzi0n
DD-WRT Guru


Joined: 10 Oct 2006
Posts: 10141

PostPosted: Thu Jul 23, 2009 21:51    Post subject: Reply with quote
gat3way wrote:
Quote:
Posting clear examples to exploit a vulnerability that is already patched serves nothing more than to be malicious, you already made your point clear that the vulnerability exists and it has been patched.


I cannot agree with your definition of "malicious". Malicious would be setting up your own router-based botnet for example, or selling the exploit to some anonymous Russian over the net - that IMO would be malicious and vile indeed. Hiding information, even information concerning vulnerabilities does no good. Anyway, that's just my personal viewpoint.

That's a topic of great debate in the security community. IMO it is rather malicious to post vulnerabilities without notifying developers and giving them moderate time to release a patch. I also find it malicious to hand people code that could easily be used by people with little knowledge (ie. 'script kiddies') to exploit the vulnerability. At first I thought that maybe you were being kind enough to use an example that would break for these people but now it seems you don't care if people get exploited.

If you look over my posts from the last few days I think you'll find that I tried to clarify the misinformation as much as I could, even when it came from the developers, but I can not agree with posting further code that can easily be used to exploit unpatched routers.

_________________
Read the forum announcements thoroughly! Be cautious if you're inexperienced.
Available for paid consulting. (Don't PM about complicated setups otherwise)
Looking for bricks and spare routers to expand my collection. (not interested in G spec models)
gat3way
DD-WRT Novice


Joined: 23 Jul 2009
Posts: 4

PostPosted: Thu Jul 23, 2009 22:23    Post subject: Reply with quote
That's alright, I will not be aiding further anyone at least here any more.

As for the disclosure ethics, I have my personal reasons for not notifying the vendor and it is mostly related to authors' response to the last year's CSRF vulnerabilities discovered. "I don't see how this can be a problem" and having the latest stable version still vulnerable to those months after that is not the right response IMO. Hopefully now they will reconsider those problems, at least I hope so.

Yeah, the users base may be endangered in that scenario but then again would it be better if it was a private 0day blabla thing exchanged in some hackerish forums with dd-wrt users still vulnerable to it? At least (thankfully) now a patch was released quick, with an advisory on the front page and stuff.
chris
Site Admin


Joined: 06 Jun 2006
Posts: 101
Location: Germany, Bensheim

PostPosted: Thu Jul 23, 2009 22:34    Post subject: Reply with quote
HI gat3way,

contacting us would not have changed the behavior, i can promise you.

_________________
NewMedia-NET GmbH
Christian Scheele (CEO)
http://www.dd-wrt.com
phuzi0n
DD-WRT Guru


Joined: 10 Oct 2006
Posts: 10141

PostPosted: Thu Jul 23, 2009 23:53    Post subject: Reply with quote
gat3way wrote:
Yeah, the users base may be endangered in that scenario but then again would it be better if it was a private 0day blabla thing exchanged in some hackerish forums with dd-wrt users still vulnerable to it? At least (thankfully) now a patch was released quick, with an advisory on the front page and stuff.


How would you describe milw0rm.org? In their own words:

<meta name="description" content="milw0rm exploits and 0day exploits database">

It may not be a private site but it certainly seems distinctly blackhat. I thank you for disclosing it publicly at least, but I disagree with your methods and question your ethics.

_________________
Read the forum announcements thoroughly! Be cautious if you're inexperienced.
Available for paid consulting. (Don't PM about complicated setups otherwise)
Looking for bricks and spare routers to expand my collection. (not interested in G spec models)
axelm
DD-WRT User


Joined: 03 Oct 2008
Posts: 313

PostPosted: Fri Jul 24, 2009 0:15    Post subject: Reply with quote
Wouldn't it be better to have httpd bound only to 127.0.0.1:80 and to use an ssh port redirection to access the web ui? No need for iptables rules.

At least that's what I do with webmin on the office LAN.
phuzi0n
DD-WRT Guru


Joined: 10 Oct 2006
Posts: 10141

PostPosted: Fri Jul 24, 2009 0:36    Post subject: Reply with quote
axelm wrote:
Wouldn't it be better to have httpd bound only to 127.0.0.1:80 and to use an ssh port redirection to access the web ui? No need for iptables rules.

At least that's what I do with webmin on the office LAN.

Micro builds don't have ssh. There's many ways to lock down your router if you must use an old build; the iptables rule on the main page is just one that works across all builds for people using default web admin settings (http not https).

_________________
Read the forum announcements thoroughly! Be cautious if you're inexperienced.
Available for paid consulting. (Don't PM about complicated setups otherwise)
Looking for bricks and spare routers to expand my collection. (not interested in G spec models)
axelm
DD-WRT User


Joined: 03 Oct 2008
Posts: 313

PostPosted: Fri Jul 24, 2009 0:53    Post subject: Reply with quote
phuzi0n wrote:
axelm wrote:
Wouldn't it be better to have httpd bound only to 127.0.0.1:80 and to use an ssh port redirection to access the web ui? No need for iptables rules.

At least that's what I do with webmin on the office LAN.

Micro builds don't have ssh. There's many ways to lock down your router if you must use an old build; the iptables rule on the main page is just one that works across all builds for people using default web admin settings (http not https).


1) I'd never consider using a router that does not support ssh, specially not an edge router.
2) You are only avoiding this particular http exploit with the iptables rule. Unbinding httpd from the LAN and the WAN avoids http exploits altogether.
phuzi0n
DD-WRT Guru


Joined: 10 Oct 2006
Posts: 10141

PostPosted: Fri Jul 24, 2009 1:12    Post subject: Reply with quote
axelm wrote:
1) I'd never consider using a router that does not support ssh, specially not an edge router.
2) You are only avoiding this particular http exploit with the iptables rule. Unbinding httpd from the LAN and the WAN avoids http exploits altogether.

This is the broadcom based hardware forum ie. embedded devices with varying flash and ram sizes. Barely anything fits into 2MB flash that the micro builds are meant for and these devices are particularly common home routers due to their low costs. The majority of supported broadcom devices are marketed for home use and as such they need to be easy to configure.

Your solution is great for network admins but not for the average joe flashing their sub $100 router.

_________________
Read the forum announcements thoroughly! Be cautious if you're inexperienced.
Available for paid consulting. (Don't PM about complicated setups otherwise)
Looking for bricks and spare routers to expand my collection. (not interested in G spec models)
VValdo
DD-WRT Novice


Joined: 13 Apr 2009
Posts: 24

PostPosted: Fri Jul 24, 2009 3:30    Post subject: Reply with quote
Some quick thoughts--

I do remember the response in the forum and cavalier attitude in IRC the last time this happened in December '08 (and it's still not patched in the latest release version, is it?), so to some extent I understand where Gat3way is coming from.

Quote:
Posting clear examples to exploit a vulnerability that is already patched serves nothing more than to be malicious


I have to say, I'm not a big fan of obscurity. Someone will write a script for the kiddies one way or another, and I kinda feel it's detailing potential attack vectors that wake people up to take this seriously.

Personally speaking, I'm thankful that Gat3way publicly exposed the issue and continues to post his or her ongoing security concerns publicly, rather than what s/he could have done, which is not told anyone or told the wrong people. Who knows how many others have previously discovered this hole and said nothing or exploited it for their own advantage? Do I wish Gat3way had discreetly gone to the developers first? Yeah. But I wonder if a fix would have quietly been slipped into svn builds, and would we have still seen an announcement so quickly on the front page?

Posting "clear examples" of exploits allows for a public discussion where the eyeballs of knowledgeable experts here on this forum can discuss whether or not the patch is sufficient to fix the problem. In this case, Gat3way is suggesting it doesn't completely do so.

Also, I think it's really unfair to call Gat3way's posting of potential attack vectors "malicious". If Gat3way wanted to be malicious, there were other ways s/he could have done so. I don't see the wisdom in attacking (and discouraging from participating) the "ethics" of someone who's not only pointed out two gaping security holes, but continues to point out why current fixes do not fully address the problem. If you don't like the way s/he disclosed the holes, fine. But as I see it, Gat3way is doing everyone here a net favor (pun intended).

Quote:
you already made your point clear that the vulnerability exists and it has been patched.



When the person who found these holes says that the developers current solution is "weak" (because attacks can still be made via https), I'd listen.

Comments on this thread like "Lets move on.." and "Non forum members don't know?? So what?? It's been patched, work around's have been posted. Not my (our) problem." and "Yes the exploit exists. So what? Upgrade your firmware already and move on." and "Stop posting then, this thread will fade to the background. And calm down." are totally irresponsible IMO. "Let's move on" and hope no one notices leaves thousands of boxes exploitable.

The problem is that people running old versions need to be notified so they know to update. This necessarily involves notifying potential hackers. But the lets-keep-it-hush-hush-and-move-on alternative means the "clear exploit" circulating only in the hacker community without ever notifying the average dd-wrt user at all.

I'm glad to see a security list is being started. I do think someone needs to re-write the description of the bug on the front page to make it clearer, especially if a redo on the fix is coming. I'm happy to give it a pass.

W
Goto page Previous  1, 2, 3 ... 10, 11, 12, 13, 14, 15  Next Display posts from previous:    Page 11 of 15
Post new topic   Reply to topic    DD-WRT Forum Index -> Broadcom SoC based Hardware All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum