Improve stability

Post new topic   Reply to topic    DD-WRT Forum Index -> Marvell MVEBU based Hardware (WRT1900AC etc.)
Goto page Previous  1, 2, 3, 4  Next
Author Message
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 1952

PostPosted: Sat Apr 22, 2023 18:03    Post subject: Reply with quote
blkt wrote:
https://github.com/kaloz/mwlwifi/pull/408#issuecomment-1518631176

https://github.com/kaloz/mwlwifi/commit/9f991fdee60e7b251177d911b6def2a77c1259c9

Exactly. The collective information from PR #408 and the other links I provided to point to where I was leading which you so eloquently pin-pointed. <applause>

It seems this applies to post-update the driver/firmware to 10.3.9.0-20230311, not prior to. Is DD-WRT using said driver/firmware update?

_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.5
Sponsor
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Sat Apr 22, 2023 18:13    Post subject: Reply with quote
Not true, just #408, and yes it is the same patch.
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 1952

PostPosted: Sat Apr 22, 2023 18:51    Post subject: Reply with quote
https://github.com/openwrt/openwrt/issues/12430#issuecomment-1518028206

https://github.com/openwrt/openwrt/pull/12373#issuecomment-1518123397

_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.5
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Sat Apr 22, 2023 19:06    Post subject: Reply with quote
blkt wrote:
https://github.com/kaloz/mwlwifi/pull/408#issuecomment-1518631176
https://github.com/kaloz/mwlwifi/commit/9f991fdee60e7b251177d911b6def2a77c1259c9
blkt wrote:
Not true, just #408, and yes it is the same patch.
Anyway, about the ongoing #409 conversation see a minor debug annoyance.
#410 & #411 closed; these occurred before disconnection isolated to commit.
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 1952

PostPosted: Sat Apr 22, 2023 20:57    Post subject: Reply with quote
Exactly. Apologies for not connecting all the dots with a complete set of links, but something told me that you'd champion that effort, as always. Also, the "20230311" seems to simply be a reference to the merge of #408, which could cause confusion for some...
_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.5
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Sat Apr 22, 2023 21:10    Post subject: Reply with quote
Focus on upstream mwlwifi, not OpenWrt and they decided to rename subject.
Since there is now a patch for testing an email is sitting in BrainSlayer's inbox.

https://github.com/kaloz/mwlwifi/issues/409#issuecomment-1518772941
https://github.com/jbsky/mwlwifi/commit/fa54ce536bc57aa2d040d116d47a7ed4d258fef8

https://github.com/kaloz/mwlwifi/issues/409#issuecomment-1518831894

https://github.com/kaloz/mwlwifi/pull/412/commits
oliver44
DD-WRT Guru


Joined: 01 Jun 2016
Posts: 504

PostPosted: Tue Apr 25, 2023 17:06    Post subject: Reply with quote
A new fix!

https://github.com/kaloz/mwlwifi/pull/412

_________________
Internet provider https://en.wikipedia.org/wiki/RCS_%26_RDS 1Gbps
WDR3600 rev.1.5 - DD-Wrt
Linksys WRT1900ACS v.2 DD-Wrt/-OpenWrt



https://ipv6.chappell-family.com/ipv6tcptest/
https://en.internet.nl/connection/e91f490fe1c54cb2b78145c0ab0d2b5a/results
http://www.dnssec-or-not.com/
https://dnscheck.tools/#results
saphirely
DD-WRT User


Joined: 13 Dec 2020
Posts: 270

PostPosted: Tue Apr 25, 2023 18:45    Post subject: Reply with quote
My Linksys WRT1900ACS v1

WiFi is stable on DD-WRT v3.0-r52369 std (04/20/23).

How ever, FreeBSD 13.2 amd64 NIC realtek r8169 driven by re0 is impossible to connect router what ever dhcp or fixed ip. On the other hand, the 2nd USB NIC ue0 can connect in 1 min only. These trouble is not exist in any Linux or Windows.
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 14246
Location: Texas, USA

PostPosted: Wed Apr 26, 2023 1:06    Post subject: Reply with quote
oliver44 wrote:
A new fix!

https://github.com/kaloz/mwlwifi/pull/412

Yes, those following along are already aware.

blkt wrote:
Focus on upstream mwlwifi, not OpenWrt and they decided to rename subject.
Since there is now a patch for testing an email is sitting in BrainSlayer's inbox.

https://github.com/kaloz/mwlwifi/issues/409#issuecomment-1518772941
https://github.com/jbsky/mwlwifi/commit/fa54ce536bc57aa2d040d116d47a7ed4d258fef8

https://github.com/kaloz/mwlwifi/issues/409#issuecomment-1518831894

https://github.com/kaloz/mwlwifi/pull/412/commits

The diversion was from the OP and reiterated (unfortunately), but the focus was on Mr. Kaloz' repo the whole time, including the overall discussion which is not anywhere on GitHub. Still waiting to see this committed to DD-WRT Official.

_________________
"Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT
Pogo - A minimal level of ability is expected and needed...
DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)

----------------------
Linux User #377467 counter.li.org / linuxcounter.net
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Wed Apr 26, 2023 4:35    Post subject: Reply with quote
oliver44 wrote:
A new fix!

https://github.com/kaloz/mwlwifi/pull/412
3 days ago same #409 patch (see #412 commit) fixed disconnection, a regression or bug from "improve stability".
Tests were successful, except pesa1234 who removed debug (bad commit/fix attempt) but is properly commented.
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 14246
Location: Texas, USA

PostPosted: Thu Apr 27, 2023 19:15    Post subject: Reply with quote
Apparently, there are differences in line numbers in the mac80211.c file as there are differences between DD-WRT source code and upstream, as I discovered - probably related to kernel version(s) in use as upstream is being maintained for a Linux 5.x.x kernel, not a Linux 4.9.x kernel. I opened a PR on GitHub to see if that would garner any further attention than your email. So far, I have seen no visible action on this from BS.

Fix disconnection issue / update driver version for mwlwifi

#teamwork

_________________
"Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT
Pogo - A minimal level of ability is expected and needed...
DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)

----------------------
Linux User #377467 counter.li.org / linuxcounter.net
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Thu May 04, 2023 7:00    Post subject: Reply with quote
r52411 "revert antenna chainmask settings for mwlwifi. it seems to cause troubles with intel chipsets"
r52424 "readd with corrections"

@BrainSlayer please review mwl_vif->is_hw_crypto_enabled = false;
no response to emails for almost two weeks but request in summary:
either revert a single problematic line or go with the current solution.
nickant
DD-WRT User


Joined: 09 Feb 2016
Posts: 321

PostPosted: Fri May 05, 2023 1:02    Post subject: Reply with quote
I've left my WRT3200ACM on r52330 for now.
Should I be waiting for r52424 rather than use r52411, or just stick to r52330 until the dust settles on these developments?
Edit: r52411 build got pulled, so question answered.

_________________
------------------------------------
Linksys WRT3200ACM DD-WRT r55819 (Gateway)
Linksys EA8500 OpenWrt-23.05.3 (Wired AP)
Netgear WNDR3700v4 DD-WRT r55819 (spare Gateway)
Photos: https://www.flickr.com/photos/nickant44/albums
blkt
DD-WRT Guru


Joined: 20 Jan 2019
Posts: 5700

PostPosted: Sun May 07, 2023 12:30    Post subject: Reply with quote
Just noticed comment, but since hidden behind driver changelog can only hope applies to Marvell, for next release.

r52453 "fix disconnect issue"
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 14246
Location: Texas, USA

PostPosted: Mon May 08, 2023 5:08    Post subject: Reply with quote
Guess we'll see-ish. Don't plan on closing PR until public tree shows evidence.
_________________
"Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT
Pogo - A minimal level of ability is expected and needed...
DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)

----------------------
Linux User #377467 counter.li.org / linuxcounter.net
Goto page Previous  1, 2, 3, 4  Next Display posts from previous:    Page 2 of 4
Post new topic   Reply to topic    DD-WRT Forum Index -> Marvell MVEBU based Hardware (WRT1900AC etc.) All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum