My patch would have worked fine for 99% of users, except for really edge cases where users may import configs from other routers or manually set rc_usb variables via CLI.
Not when both client devices shown use this or similar default nvram variable:
Of course, the TL-WA901NDv2 probably needs a hard reset as it may have a carryover nvram variable from older firmware versions, but on current version, it resets that rc_usb= nvram variable <wink>
the-joker wrote:
egc wrote:
Thank you @dale_gribble39 for your solution.
You mean thank you brainslayer for the solution.
Yes, it was Mr. Gottschall's patch, not mine, nor anyone else's <lol> <eyeroll> _________________ "The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost
"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio
Joined: 18 Mar 2014 Posts: 12837 Location: Netherlands
Posted: Mon Oct 03, 2022 16:17 Post subject:
I will certainly have a look but at the moment busy with looking into WireGuard obfuscation.
WireGuard cannot pass the Great firewall (and also can be blocked by other firewalls).
But there are some obfuscation techniques similar as we use for OpenVPN which are going to be tested the next weeks and if it works will be added to WireGuard
But indeed javascript has C style comments and html <-- -->.
However I think (and I am not 100% sure) that the strip/compress code also strips all lines starting with // from HTML pages so if a HTML line starts with it the whole line should also be stripped entirely although of course it is not good programming _________________ Routers:Netgear R7000, R6400v1, R6400v2, EA6900 (XvortexCFE), E2000, E1200v1, WRT54GS v1.
Install guide R6400v2, R6700v3,XR300:https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=316399 Install guide R7800/XR500:https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=320614 Forum Guide Lines (important read):https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=324087
As you can see, using */ and /* in changeset 50312 fixed that issue with the Save Custom button being hidden/missing because, javascript. However, the other original code being encapsulated in html/asp, the double <!-- --> comment tags related to USB were improperly rendered, resulting in a cosmetic issue. Easiest way to confirm my suspicion is if you can compile a test image for a device with no USB port/support and test. Of course, my OCD says that the Save USB button should be *after* the Save Custom button because it is after Save Custom in *ALL* of the associated code elsewhere, and the Save USB feature is more recent than the Save Custom. It's not that big of a deal if the current code works, but it would be nice to confirm yea or nay if the issue fixed in 50312 was the underlying issue for rendering or if it were related to order of buttons or both. Of course, I just got a reply asking why I'm still discussing it, so, probably just leave it alone and not bother. I have it on a back burner myself, not a priority. So, disregard and don't poke the bear unless you really want to _________________ "Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT Pogo - A minimal level of ability is expected and needed... DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)
----------------------
Linux User #377467 counter.li.org / linuxcounter.net
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Mon Oct 10, 2022 12:48 Post subject:
You can nag, I may not listen Most importantly, the more options you try to add the chances BS will shoot it down.
Problem is if I make it permanent you will have the other users to contend with. the only way to please everyone is to make it optional and one toggle would work fine for both with minor label change.
Most importantly, the more options you try to add the chances BS will shoot it down.
How about the same nvram variable sticky_footer, but 0 for disable all, 1 for sticky footer only, 2 for sticky sidebar only, and 3 for both sticky footer and sticky sidebar? The toggle button needs to be changed to drop-down list.
the-joker wrote:
Who reads help anything really?
I see that the help text is updated now and then, so I guess there's no plan to kill the help sidebar yet. I guess you've already got the framework for the sticky footer, so I think it's good to make the help sidebar sticky also, because I think the sticky help sidebar is more useful (at least for new users) and it doesn't take up any vertical space as the sticky footer.
But for extreme minimalists:
mrjcd wrote:
...then again, dare I say, who needs silly webif anyways
the-joker wrote:
Yea you're right! Who needs a webif? Lets rip it out and go commando lino only-o
On 50474, kromo UI style logout button not readily visible:
Screenshot 2022-10-11 095202.png
Description:
Filesize:
89.81 KB
Viewed:
1038 Time(s)
Screenshot 2022-10-11 095239.png
Description:
Filesize:
90.04 KB
Viewed:
1039 Time(s)
_________________ "The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost
"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio
Posted: Wed Oct 12, 2022 15:00 Post subject: Expand these boxes
Any chance the DDNS Hostname text box and the Secure Shell (SSH) Autharized Keys text box
can be expandable so to show entire contents same as VPN Certificate and many others?
When creating and using pdf bakups it would be nice if these text strings could be copied .
Asking for a friend