Joined: 08 May 2018 Posts: 14217 Location: Texas, USA
Posted: Sun Oct 17, 2021 10:56 Post subject:
Yes subversion has it's limitations, but the decision was made long ago that it will be the de-facto code revision environment for DD-WRT. The github mirror was not established by DD-WRT, but as soon as BS knew it existed, he polled github to allow him to own it. Otherwise, you would be in trouble, most likely - and having to submit patches the fun way _________________ "Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT Pogo - A minimal level of ability is expected and needed... DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)
----------------------
Linux User #377467 counter.li.org / linuxcounter.net
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Sun Oct 17, 2021 14:56 Post subject:
Actually SVN is probably better for content such as DD-WRT source.
In fact Brainslayer's GitHub account has an outdated svn dd-wrt clone, so happens the mirrors was up to date and it's a non issue.
Git has its limitations too, it's just more convenient for pull requests/review, not that it matters, what matters is the fixes.patch URL and patch apply.
Note the colors used and feel free to check contrasts with webaim website or better.
DR;TL Regarding these areas for color blind people of all types.
It's advised to use textures or text to differentiate from different areas, not just colors, this is mostly good news for dd-wrt.
Even if the colors (as changed above) are not helpful for the color blind users to distinguish states in syslog, text is displayed .err (red) / .warn (yellow) / .authpriv.notice (green),
If you think this isn't enough for you as a color blind person leave feedback on this topic, mention your type of color blindness and any feedback you may have.
The other state colors are used in switch page, also text is always displayed there, depending on the state, I dont think anything else needs improving for color blindness at this time there, even if its not ideal.
In future this will need to be looked at and themes for each color blindness type maybe introduced at some later date. Much needs to be done yet before this happens.
Build - DD-WRT v3.0-r47567 std (10/18/21) looks better especially/help/about all bugs squashed I could find, it still has a couple issues that should be fixed when pr 68 is merged.
Keep the feedback coming.
Be well.
Edit: added color charts for diff color blindness types for the colors we now use.
contrast still falls under the preferred higher ratio and equally good for light dark base themes. Just if you're curious.
Joined: 08 May 2018 Posts: 14217 Location: Texas, USA
Posted: Mon Oct 18, 2021 15:48 Post subject:
I'm waiting for someone to start asking when the next beta will drop, lol. Looks like that one was run for all devices, so perhaps sometime today it will be uploaded to the public. If only we could convince someone that 0 and 5 are awesome numbers to stop at. _________________ "Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT Pogo - A minimal level of ability is expected and needed... DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)
----------------------
Linux User #377467 counter.li.org / linuxcounter.net
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Mon Oct 18, 2021 18:52 Post subject:
kernel-panic69 wrote:
I'm waiting for someone to start asking when the next beta will drop, lol. Looks like that one was run for all devices, so perhaps sometime today it will be uploaded to the public. If only we could convince someone that 0 and 5 are awesome numbers to stop at.
I guess when its ready, it drops.
I would never stop at awesome with only 0 and 5 as a choice, seems to me the best release is the one you really need, not the one you really want.
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Tue Oct 19, 2021 10:30 Post subject:
Hello all, small update
OK themes wise -r47573 for me is good, in this BS squashed a bug in the NAS.asp page
it actually was caused by missing closing brackets on raic.c HTML (old bug) see attachment.
But of course it didn't stop there, kernel updates have now gone in, idk what else is going to go in at this stage, nothing from me that you should notice, unless there's some themes bug which was missed. It's possible, I'm not perfect.
That's all she wrote at -r47578 at time of writing this, so two more for 0.
Be well and enjoy the attachments, see anyone even noticed that bug.
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Wed Oct 20, 2021 13:10 Post subject: DD-WRT 10-20-2021-r47581
Hello =).
So -r47581 public is out.
I already pushed theme bug fixes post -r47581, though you should only notice one of the issues under certain conditions.
1) When classic dark styles is enabled and any of the Inspired themes would be then enabled.
The issue you would see is that the about/help pages would show classic dark styles colors and not the Inspired themes colors.
So if you find this bug, its known and fixed.
Also fixed is the FilterIPMAC.asp some dots were added which also fixes the margin between inputs which was 0 before.
New things you should notice, is all classic themes disabled buttons are now the color of the style you chose and not gray. Most common one would be on Networking.asp page AKA Setup -> Networking tab, also hovering over disabled buttons is also fixed.
When classic styles are dark, the fieldset legend color i.e. any box group title, is brighter by 80%, so the contrast is minimum per WCAG. This can be adjusted down a bit if you prefer.
So lots to see no matter if you like it light or dark.
To come:
The PayPal logo to dark when classic themes are set to dark.
Joined: 16 Nov 2015 Posts: 6436 Location: UK, London, just across the river..
Posted: Thu Oct 21, 2021 5:51 Post subject:
dark cocoa is my fav , but sadly im an autist don't get on with changes that quick ...
still using the default color themes...but appreciate your effort... _________________ Atheros
TP-Link WR740Nv1 ---DD-WRT 55630 WAP
TP-Link WR1043NDv2 -DD-WRT 55723 Gateway/DoT,Forced DNS,Ad-Block,Firewall,x4VLAN,VPN
TP-Link WR1043NDv2 -Gargoyle OS 1.15.x AP,DNS,QoS,Quotas
Qualcomm-Atheros
Netgear XR500 --DD-WRT 55779 Gateway/DoH,Forced DNS,AP Isolation,4VLAN,Ad-Block,Firewall,Vanilla
Netgear R7800 --DD-WRT 55819 Gateway/DoT,AD-Block,Forced DNS,AP&Net Isolation,x3VLAN,Firewall,Vanilla
Netgear R9000 --DD-WRT 55779 Gateway/DoT,AD-Block,AP Isolation,Firewall,Forced DNS,x2VLAN,Vanilla
Broadcom
Netgear R7000 --DD-WRT 55460 Gateway/SmartDNS/DoH,AD-Block,Firewall,Forced DNS,x3VLAN,VPN
NOT USING 5Ghz ANYWHERE
------------------------------------------------------
Stubby DNS over TLS I DNSCrypt v2 by mac913
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Fri Oct 22, 2021 12:22 Post subject:
Wildlion wrote:
These look like great improvements... Thank you! Not sure when I will get to upgrade.
Thanks, and you're welcome. It depends on you when an how, or if newer builds works with your setup. But the older the builds the more security holes it will have, not that it matters in most cases. =)
They will be waiting for you whenever that upgrade time comes. So no rush =)
Alozaros wrote:
dark cocoa is my fav , but sadly im an autist don't get on with changes that quick ...
still using the default color themes...but appreciate your effort...
Any change is hard for some people no matter what.
The classic themes are also getting some love. both dark and light.
But if you really wanted to talk real change as in its completely alien to what it was before, then that hasn't happened at all in any of the themes, its just colors and how they are applied to the old(er) design, which I like FYI.
If I ever want to do something really different/modern it will be done outside of the built in themes before it even gets anywhere near the core.
first of all best thanks
i think the syslog is now well readable
looking around i found a little bug in the brainslayer skin though
the syslog overlaps
and in the speedchecker tab the colors are not correct (if you can change that)
oh and the bandwidth graph is not centered right or too small or whatever (do not know if that would look better otherwise)
Joined: 31 Jul 2021 Posts: 2146 Location: All over YOUR webs
Posted: Fri Oct 22, 2021 13:11 Post subject:
ho1Aetoo wrote:
first of all best thanks
i think the syslog is now well readable
You're welcome. It is a special area where people need in no uncertain way not be required to squint to be able to read it. =)
ho1Aetoo wrote:
looking around i found a little bug in the brainslayer skin
Thanks but well outside the purview of this topic.
the-joker wrote:
To find any issues visually with both;
Classic (light/dark) any color of the blue/cyan/elegant/green/orange/red/yellow
Inspired Themes (any) and report back. with your lovely pieces of snip art we call screenshots and perhaps a page link, yes that would be a nice touch.
I have not touched xirian/kromo/brainslayer/wikar or intend to at this time, they are 100% independent of the themes I'm working on as above, this is not to say some time in the future it wont happen.
So thanks again in any case. If you want to make a note of any bugs you find with those please do, I suggest even creating a new topic (you dont have to unless you really want to) and wack all those reports in there, eventually it will be a good place for me to find all that nice and neat pre-testing and reports under one place.
...
