UI themes! preview/public builds BUG hunting REPORTING

Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions
Goto page Previous  1, 2, 3 ... 9, 10, 11 ... 20, 21, 22  Next
Author Message
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Thu Jul 28, 2022 11:59    Post subject: Reply with quote
ho1Aetoo wrote:

To reproduce the whole thing just reset the router and set a new password

the following special characters are accepted and work:

Code:
~!@#$%&()-_=+[]{}\;,.<>/?|



the following special characters are not accepted:

Code:
^:*



the following special characters are accepted but make the authentication impossible:

Code:
`'"


I just wanted to say that I have figured it out

https://svn.dd-wrt.com/ticket/7404#comment:16

Is still a bug in my opinion
Sponsor
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 14217
Location: Texas, USA

PostPosted: Thu Jul 28, 2022 15:04    Post subject: Reply with quote
Fixed: https://svn.dd-wrt.com/changeset/49584
_________________
"Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT
Pogo - A minimal level of ability is expected and needed...
DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)

----------------------
Linux User #377467 counter.li.org / linuxcounter.net
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Thu Jul 28, 2022 15:19    Post subject: Reply with quote
Well, not really, because the symbol backstick is missing, which is used by many gernerators.
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 14217
Location: Texas, USA

PostPosted: Thu Jul 28, 2022 16:12    Post subject: Reply with quote
Forgot to turn off audible. I sent BS an email about this. You can configure password generators to not use these invalid characters. Back to dark room and no noise.

UPDATE/EDIT 07.29.22.06.25: It looks as if the password character issue has been readdressed further, requiring more documentation changes.

https://svn.dd-wrt.com/changeset/49586
https://svn.dd-wrt.com/changeset/49588
https://svn.dd-wrt.com/changeset/49589
https://svn.dd-wrt.com/changeset/49590
https://svn.dd-wrt.com/changeset/49591

_________________
"Life is but a fleeting moment, a vapor that vanishes quickly; All is vanity"
Contribute To DD-WRT
Pogo - A minimal level of ability is expected and needed...
DD-WRT Releases 2023 (PolitePol)
DD-WRT Releases 2023 (RSS Everything)

----------------------
Linux User #377467 counter.li.org / linuxcounter.net
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Sat Jul 30, 2022 7:12    Post subject: Reply with quote
OK Since build r49599

valid special characters

Code:
!"#$%&'()*+,-./;<=>?@[\]^_`{|}~


invalid special characters

Code:
:

(Collon and Space)

See also https://en.wikipedia.org/wiki/List_of_Special_Characters_for_Passwords

I recommend to use the above listed notation (because it is sorted with | sort)

Now only the help text would have to be adapted.

A question to the UI expert wouldn't the following be nicer?

Code:
Valid !"#$%&'()*+,-./;<=>?@[\]^_`{|}~
Invalid :


or

Code:
Valid Characters !"#$%&'()*+,-./;<=>?@[\]^_`{|}~
Invalid Characters :


or

Code:
Valid Symbols !"#$%&'()*+,-./;<=>?@[\]^_`{|}~
Invalid Symbols :


Last edited by ho1Aetoo on Sat Jul 30, 2022 8:13; edited 1 time in total
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 7:24    Post subject: Reply with quote
So you want to show the tooltip/aria-label with the valid characters instead of the invalid? Or you want to show both invalid and valid?

Im asking to see what the logic here is, its the morning I have had no coffee but I think it should be obvious that unless something is specifically blacklisted that logically everything else should be accepted, and there fore not worth mentioning...

But, if we must design a idiot friendly solution, I fist want to understand what the logic behind the suggestion is.

And are those now all tested and confirmed to work?

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)


Last edited by the-joker on Sat Jul 30, 2022 7:29; edited 1 time in total
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Sat Jul 30, 2022 7:35    Post subject: Reply with quote
can't you display both in two lines for the sake of completeness? (maybe a stupid question idk)

yes they work i just use the valid symbols as password

Quote:
Im asking to see what the logic here is, its the morning I have had no coffee but I think it should be obvious that unless something is specifically blacklisted that logically everything else should be accepted, and there fore not worth mentioning...


the average user would first have to know which symbols are allowed as passwords (see wiki article).

there are also other symbols on the keyboard like °´ etc which are not supported

but only a suggestion
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 8:17    Post subject: Reply with quote
Wouldn't having just a definitive list of what is not supported suffice?

I mean Grave accent ` aka backtick was removed from the JS validation, you are saying that when used it will break authentication?

The degree symbol is obviously not in the Wikipedia entry but the colon is and backtick are part of list the colon was kept as invalid for some reason. I had already spoken to BS about this, that most modern websites accept all current and previously blacklisted characters.

Password generators wont use the ° character or other not listed special characters, sure you can very likely add it manually as most interface based password gens will allow users to customize the entries, but that is an edge case.

We definitively need to know since you are so kindly testing and that is appreciated, what exactly breaks authentication within the normal accepted character list, all else we will consider in the new implementation.

Any implementation of any kind of help design, needs to be implemented in the Management.asp and changepass.asp (which I have currently already added to the existing design)

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Sat Jul 30, 2022 8:25    Post subject: Reply with quote
no symbol currently breaks the authentication
Everything is fixed.


backstick ` works

the only two symbols that do not work are : (collon) and (space)

There is a message : invalid symbol
or in the password no spaces are allowed

or invalid ASCII symbol °´ <- not a backstick

The characters I have listed as valid or invalid are all correct according to the linked wiki article and are even sorted correctly!



8111111111130.png
 Description:
 Filesize:  30.29 KB
 Viewed:  883 Time(s)

8111111111130.png


the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 8:50    Post subject: Reply with quote
Ah the Acute accent ´ sorry, not caffeinated enough, though you are showing the degree and acute accent, Ill assume both and disregard them as they are not standard or used in most password gens. Ive mentioned it to BS, so that it can be shown as invalid also.

That and the degree symbol and many others aren't standard on any password gens, Ill need to update my own gen now also.

So really only the colon is invalid for some reason, likely a delimiter somewhere. Still I use it on non DD-WRT passwords on some other web services.

I'll consider the information you have kindly provided when I next update the current help mechanism and in meanwhile I need to think of alternative help mechanisms to suit DD-WRT.

Thanks.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Sat Jul 30, 2022 9:07    Post subject: Reply with quote
The two symbols °´ were just an example of what happens when you use unsupported characters.

These are extended ASCII characters and there are a lot of them - you don't have to list them.

That was just a test.

https://www.ascii-code.com/
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 9:14    Post subject: Reply with quote
Sure, Im wondering though when they are flagged as illegal, if they arent shown for a valid reason on the popup message.
_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 11:10    Post subject: Reply with quote
Test https://github.com/mirror/dd-wrt/pull/302/files

Its all encoded hopefully not to interfere with JS.

The space is pointless as it renders as a final space

https://ttsreader.com/ shows this as a complete disaster, some are ignored completely.

P.S. haven't tested all screen readers but a workaround would be to define these as text separately.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)


Last edited by the-joker on Sat Jul 30, 2022 11:45; edited 1 time in total
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 2972
Location: Germany

PostPosted: Sat Jul 30, 2022 11:44    Post subject: Reply with quote
I have copied it to dev console.
of course the second line is missing.

Looks actually quite good?
Hope of course that it causes no problems.
and I hope of course that the users find / see it

maybe the label "symbols" or "special character" would be clearer?

see https://wmich.edu/arts-sciences/technology-password-tips



8111111111132.png
 Description:
 Filesize:  33.4 KB
 Viewed:  815 Time(s)

8111111111132.png




Last edited by ho1Aetoo on Sat Jul 30, 2022 11:49; edited 1 time in total
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2146
Location: All over YOUR webs

PostPosted: Sat Jul 30, 2022 11:47    Post subject: Reply with quote
IF you want to hack the two lines, you will need to use &013; or &13; at the end to force newline, within the HTML this is \n, untested obviously.
_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
Goto page Previous  1, 2, 3 ... 9, 10, 11 ... 20, 21, 22  Next Display posts from previous:    Page 10 of 22
Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum