Joined: 31 Jul 2021 Posts: 2142 Location: All over YOUR webs
Posted: Sat Oct 16, 2021 8:15 Post subject: UI themes! preview/public builds BUG hunting REPORTING
Hello to everyone , I am the person working on the UI (internal themes) for DD-WRT.
As a result, recently I was introduced to the FTP server @Brainslayer hosts and is now building preview builds for my RT-AC68U and other targets, if you are a tester and ask for them, I'm sure they will be built, if they aren't already.
I have a challenge of sorts, since the UI refresh as been going forward and would like see about any possible issues one pair of tired old myopic eyes can easily miss.
Work was also done to both light/dark about/help pages (yes classic styles go where no classic theme went before (if you ever noticed). 8-p
Good evening, Mr. Hunt. Your mission, should you choose to accept it;
To find any issues visually with both;
Classic (light/dark) any color of the blue/cyan/elegant/green/orange/red/yellow
Inspired Themes (any) and report back. with your lovely pieces of snip art we call screenshots and perhaps a page link, yes that would be a nice touch.
If you can Mr. Hunt, written feedback would be also welcome.
Mr. Hunt, the target preview build is 10-15-2021-r47566 to start and newer, if bugs are found and fixed.
⚠️ ctrl+F5 of shit+F5 you browsers with new builds so old cached CSS is released.
Good luck, Mr. Hunt.
This message will self-destruct in 5 seconds.
Last edited by the-joker on Wed Dec 08, 2021 8:21; edited 5 times in total
Well I use the skin elegant (without any themes)
And few colors have changed.
For example in syslog and the change is hard to read (white font on red background)
I don't know who did this, but I'll just note it here
looks like an anti aliasing problem - or what ever
"Mr. Hunt" ... it will always be "Mr. Phelps" too me...
I have to agree with ho1Aetoo... using default "elegant" on the syslog, when there is red highlighting on the text, it is hard to read (Firmware: DD-WRT v3.0-r47528 std (10/10/21))... I have worked around this by highlighting the text with the mouse.
When I try the preview button, most of them do not change (ie the basic colors), I have to use the save button, but the ones that change teh schema does work on preview...
To be honest, I am a simple person and the default "elegant" I like (also not artistic)... I have noticed text/buttons have moved slightly from previous builds... I really appreciate the "red" background on the "warnings" on the background of things like backup and firmware upgrade (makes it pop)...
The only suggestion I might have is that on the grouping of settings, there is the outline box, could the inside of the box be slightly different than the general background (or vise versa). I am not artistic but the contrast might make it set off a little better.
Joined: 31 Jul 2021 Posts: 2142 Location: All over YOUR webs
Posted: Sat Oct 16, 2021 15:40 Post subject:
I am the person working on the themes. Hence I made this thread.
Some information about contrast.
To keep a minimum of AA contrast for normal text is important and I agree is not (work in progress), was not its even worst, please check here https://webaim.org/resources/contrastchecker/
#666 foreground and #EA0707 is a 1.23:1 contrast ratio and fails all tests, this is as it was before.
If I increase text to #fff it will pass minimum AA standard for normal text and pass all for all font sizes, it has a 4.63:1 contrast ratio, in this case more is better.
When I look at the reduced screenshots in the forum and compare.
Then I can read the dark font on red backround from 50cm distance and with white on red it becomes difficult.
Joined: 31 Jul 2021 Posts: 2142 Location: All over YOUR webs
Posted: Sat Oct 16, 2021 16:09 Post subject:
Wildlion wrote:
"Mr. Hunt" ... it will always be "Mr. Phelps" too me...
It always will be, but Mr. Phelps the bug hunter does not sound so tongue in cheek, Tom Cruise has nothing to do with this. Artistic liberty or some such excuse!
How about these potential solution; see screenshot
yes, the contrast ratio is better in both variants and they are more legible.
If I judge this purely by my personal feeling, however, the first variant would still win.
Joined: 31 Jul 2021 Posts: 2142 Location: All over YOUR webs
Posted: Sat Oct 16, 2021 16:51 Post subject:
Its must be the light red and black text version, because we must consider contrast when themes are dark. Yep that matters too.
These colors are hardcoded in the cgi because the syslog is rendered on an iframe, not that it matters. but for now, lets just say that changing this to use CSS classes would need more time and testing, and that is something for later.
Ill try to get to this because all the colors for other syslog states need evaluating.
"Mr. Hunt" ... it will always be "Mr. Phelps" too me...
It always will be, but Mr. Phelps the bug hunter does not sound so tongue in cheek, Tom Cruise has nothing to do with this. Artistic liberty or some such excuse!
, I get what you originally did now!! facepalm... and to KP69 ... lol I got your reference as well ...
@the-joker, that is a great link (am book marking it for future). I will keep an eye out for anything funny for you.
Joined: 31 Jul 2021 Posts: 2142 Location: All over YOUR webs
Posted: Sun Oct 17, 2021 7:28 Post subject:
Wildlion wrote:
, I get what you originally did now!! facepalm... and to KP69 ... lol I got your reference as well ...
@the-joker, that is a great link (am book marking it for future). I will keep an eye out for anything funny for you.
Appreciate the work you are doing!
@Wildlion, appreciated, though I.m unsure what you think would be funny for me. But you have peeked my interest in any case, will wait sitting down, because standing up, may get tired.
As for the link you mention, I presume the WCAG2.0 webaim link. I use tools like this and others when addressing accessibility issues to some extent. There are other places that look more fancy stuff in that context.
If you guys are interested in following my merge/pull requests for such related work, see https://github.com/mirror/dd-wrt/pulls/the-j0k3r, there are 22 already merged/closed (feel free to rummage through those) requests and 1 open at time of writing this.
I could even use the help reviewing the changes, sometimes more eyes catch stuff better like e.g. https://github.com/mirror/dd-wrt/pull/67/commits/d305c0f06ec05ba03d7c9c329998052ef5b9b87e like in this case I'm moving positioning properties to common.css from fresh.css and leaving color properties on fresh.css (this isn't complete yet more todo on this) but if I missed something, it will introduce some breakage.
Before anyone asks, I am SVN impaired (haven't worked with SVN over 15 years), SVN (as is in dd-wrt) cannot do pull requests the same way Git can, like you're able to see diffs in real time to catch stuff, is much simpler for reviewers, inline comments etc.
At the same time the patches created there are fully SVN compatible, and thus, BrainSlayer
doesn't have to work with Git at all, he doesn't btw.