[SOLVED] Fix for #6826 System Log viewer skips one line/page

Post new topic   Reply to topic    DD-WRT Forum Forum Index -> Contributions Upload
Author Message
yoyoma2
DD-WRT User


Joined: 24 Sep 2016
Posts: 135

PostPosted: Mon Sep 30, 2019 2:12    Post subject: [SOLVED] Fix for #6826 System Log viewer skips one line/page Reply with quote
This syslog viewer bug bothered me while fixing the cron bug. Script to reproduce the bug included in ticket 6826.

The System Log viewer skips one line per page. The UI assumes 50 lines are displayed but the cgi "script" starts in the correct spot but stops after 49 lines. The attached fix is trivial, change a greater than to a greater than or equal in this file.


Last edited by yoyoma2 on Mon Jan 06, 2020 0:36; edited 1 time in total
Sponsor
yoyoma2
DD-WRT User


Joined: 24 Sep 2016
Posts: 135

PostPosted: Mon Sep 30, 2019 14:01    Post subject: Reply with quote
BS just fixed this in changeset 41213. His fix will still display 49 lines on the first page but subsequent pages display 50 and no lines are missed which is what matters.
Display posts from previous:    Page 1 of 1
Post new topic   Reply to topic    DD-WRT Forum Forum Index -> Contributions Upload All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum