Posted: Tue Apr 15, 2014 3:29 Post subject: Confirmed: SES radiooff button bug
I am configuring another dd-wrt router and wanted to use the SES radio-off on my main router (600DHP) for quick testing, only to find out that it doesn't work.
After I went through some trouble shooting, it seems the gpio is functional, and I can see status change when I pull pin 5.
Then I went to the source, and surprisingly found out something looks like a universal bug:
In router/rc/resetbutton.c
line 1254: switch (ses_mode) {
line 1256: case 1:
... { Turn on radio and set ses_mode=0 }
line 1271: case 2:
... { Turn off radio and set ses_mode=1 }
And:
line 628: static int ses_mode = 0;
...
line 712: ses_mode = 1; {if radiooff_boot_off is set}
So, it seems the entire source could only set ses_mode into either 0 (radio on), or 1 (radio off)
But, the code to turn radio off require ses_mode=2
As a result, it seems any router that enables the ses radiooff function will be unable to turn the radio off using the ses button.
Or maybe I miss understood the code.
Last edited by AdamWu on Thu Apr 17, 2014 22:52; edited 1 time in total
Ticket http://svn.dd-wrt.com/ticket/3369 seems to be fixed since 25252. Anyone tried if the SES/WPS button now actually turns the Radio Off (or Unmounts the USB device) ?
Ticket http://svn.dd-wrt.com/ticket/3369 seems to be fixed since 25252. Anyone tried if the SES/WPS button now actually turns the Radio Off (or Unmounts the USB device) ?
24461 is the last one that I am able to install without bricking my WRT54Gv6, otherwise I wold test this