UI themes! preview/public builds BUG hunting REPORTING

Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions
Goto page Previous  1, 2, 3 ... 15, 16, 17 ... 19, 20, 21  Next
Author Message
ArjenR49
DD-WRT Guru


Joined: 05 Oct 2008
Posts: 531
Location: Helsinki, Finland

PostPosted: Wed Sep 28, 2022 12:22    Post subject: Reply with quote
Upgraded R7800 to 50274 from previous f/w version using easyddup.
I have done a total reset on the previous f/w version and a manual restore mainly from PDF printouts.

BUG:
Sorting of the two last columns (service name and state) of the active connections table does not work in f/w 50274 after opening the table from the link in the status router page. Other columns can be sorted just fine.

After a refresh of the table using the button all columns can be sorted again.
Sponsor
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Wed Sep 28, 2022 12:38    Post subject: Reply with quote
ArjenR49 wrote:
Upgraded R7800 to 50274 from previous f/w version using easyddup.
I have done a total reset on the previous f/w version and a manual restore mainly from PDF printouts.

BUG:
Sorting of the two last columns (service name and state) of the active connections table does not work in f/w 50274 after opening the table from the link in the status router page. Other columns can be sorted just fine.

After a refresh of the table using the button all columns can be sorted again.


Looks like a cache issue, old code cached headbutting new code, nothing to solve.

If the issues are gone after clearly cache which is what happened when you opened the page standalone so new code was pulled in, or pressing CTRL + F5 no point reporting them, only if they persist after clearing cache.

Thanks for report anyway.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
egc
DD-WRT Guru


Joined: 18 Mar 2014
Posts: 10784
Location: Netherlands

PostPosted: Wed Sep 28, 2022 13:30    Post subject: Reply with quote
the-joker wrote:
egc wrote:
Confirmed, Add button in MiniDLNA does not seem to work as reported by @al_bo: https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=333008


fixed already.



That was a difficult bug, correct me if I am wrong but it seems that by introducing a table header an extra child element was introduced and subsequent code then uses the "wrong" child element?

_________________
Routers:Netgear R7800, R7000, R6400v1, R6400v2, Linksys EA8500, EA6900 (XvortexCFE), E2000, E1200v1, WRT54GS v1.
Install guide R6400v2, R6700v3,XR300:https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=316399
Install guide R7800/XR500: https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=320614
Forum Guide Lines (important read):https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=324087
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Wed Sep 28, 2022 14:09    Post subject: Reply with quote
The problem is that for some reason adding <thead><tr><th> for some reason breaks some tables, but works with the wrong <tbody><tr><th>, I think it could also be fixed by shunting the button to <tfoot> like I done in the static leases table to stop the button being sorted.

So really thead/tbody is the same level child wise. Its a difficult bug only to find out why proper tables header/body assignments make a difference and why is it different. In absence of finding the real cause and we just bastardize the tables because browsers are dumb enough to believe tbody suffices and what browsers add on reflow when its missing.

Ide like to test the tfoot theory, because in reality this is what it should be for buttons.

You could ask why bother adding anything at all, and the answer would be to prevent browsers reading the html, not finding the correct table layout/format and then on reflow adding missing stuff before showing you the page, so while minimal performance hit if your PC is fast enough, on dynamic table in pages with many unbalanced trees performance is way less, more noticeable on slower systems or on pages where document.write() is used very often..

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 752

PostPosted: Wed Sep 28, 2022 16:50    Post subject: Reply with quote
kernel-panic69 wrote:
Only thing I notice on 50274 on any elegant-based UI style/theme is on Administration -> Commands:


kernel-panic69 wrote:
This is on a TL-WR1043Nv5 that I've had trying to get to flash DD-WRT and BS finally fixed the firmware images. Sorry, forgot to specify router model Rolling Eyes This device has no USB port, so no telling where that anomaly is. I've cleared and overridden cache, does not change anything.

the-joker wrote:
-snip-
the other issue no idea, cant duplicate.

Related code open

https://github.com/the-j0k3r/dd-wrt/blob/master/src/router/kromo/dd-wrt/Diagnostics.asp#L139-L140
https://github.com/the-j0k3r/dd-wrt/blob/master/src/router/kromo/dd-wrt/Diagnostics.asp#L175

Close

https://github.com/the-j0k3r/dd-wrt/blob/master/src/router/kromo/dd-wrt/Diagnostics.asp#L153-L154
https://github.com/the-j0k3r/dd-wrt/blob/master/src/router/kromo/dd-wrt/Diagnostics.asp#L177

Using dev tools its likely to give some indication where that is from as the <!-- --> are rendered comments inline.

Also the info page has a similar ifndef(USB so it be intersting to see if that issue is present there also.

Code looks OK above and USB button is not showing

Quote:
If you're referring to either the info.htm (Info Site) page or Status_Router.asp page, no similar rendered anomalies present. It's specific to the Diagnostics.asp (Administration -> Commands) page, and the "Save Custom" button is missing. See attached screenshot for "view page source".

We're enjoying a "Dad can't do certain things very well today" day here so I'm posting for him.



Screenshot at 2022-09-28 11-44-17.png
 Description:
Screenshot of associated page source.
 Filesize:  359.53 KB
 Viewed:  1029 Time(s)

Screenshot at 2022-09-28 11-44-17.png



_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.4
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Wed Sep 28, 2022 17:15    Post subject: Reply with quote
<!--<!-- yep, the end also shows -->--> which is kind of why its not rendering correctly, but since code is fine, one would have to look which open/close as my initial post is invalid for devices with no usb port.

As for the hard sales pitch, keep it away from my eyes, I wonder how Julian would react to his shtick is being usurped. Cool Rolling Eyes Rhetorically speaking of course, no retort necessary. This ain't a sausage factory, kthx.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 752

PostPosted: Wed Sep 28, 2022 18:33    Post subject: Reply with quote
Same problem on 49830 on TL-WR901NDv2, so it's not a new bug:


administration_commands.png
 Description:
 Filesize:  63.02 KB
 Viewed:  960 Time(s)

administration_commands.png



administration_commands_pagesource.png
 Description:
 Filesize:  114.48 KB
 Viewed:  960 Time(s)

administration_commands_pagesource.png



_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.4
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Wed Sep 28, 2022 20:16    Post subject: Reply with quote
Same issue so one of the code open/close is bogus with the usb stuffs. It wont be a new bug since this stuff has not changed in a decade or more on this file. Changes to the file are meaningless to this, so something either changed elsewhere or this has been a bug for a long long time. Wouldn't surprise me, quite a few decades old bugs of this type were only recently (this year) hammered.

No idea where this is conking out and not a huge priority anyway. Needs investigation the ifndef and <% nvg calls to usb crap.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 752

PostPosted: Wed Sep 28, 2022 20:45    Post subject: Reply with quote
We would have to back-track to the first build that fixed flashing / upgrading the TL-WR901NDv2 (r47032/3) and check for this, if that is the case. Lead Developer Mr. Gottschall has been contacted about this issue already.
_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.4
ArjenR49
DD-WRT Guru


Joined: 05 Oct 2008
Posts: 531
Location: Helsinki, Finland

PostPosted: Wed Sep 28, 2022 23:49    Post subject: Reply with quote
the-joker wrote:


Looks like a cache issue, old code cached headbutting new code, nothing to solve.

...


I tried changing to Chromium which did not make much difference. The rightmost columns were sometimes sorted and then sometimes not. The other columns were always OK.
Then I went back to Mozilla Firefox (Linux Mint 20.3 system) and cleared the cache using its GUI. No shortcut to be found in the GUI, but apparently Ctrl+F5 is just that and is different from the reload icon on the GUI.
In Firefox it now works as it should.

'Old code headbutting new code' sounds like reload does not reload everything from the source and run(?) every bit of code to produce the page.

(I don't know much about HTML currently works as I only ever wrote very simple HTML code in the early days. Back when at my job they made secretaries edit HTML code with a text editor ... which in at least one case resulted in an irate fear of computers and keyboards, and early retirement after a long sick leave.)

I haven´t had problems with Firefox before the recent sorting issue (the bug some days ago) even though all I am used to do is reload a page.
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Thu Sep 29, 2022 11:53    Post subject: Reply with quote
Reload or simple refresh or F5 (all the same action) uses cached content where possible to speed up loading any given page. It does not clear anything browser cache related.

Browsers cache CSS/HTML/JavaScript and other resources for all websites to make them faster to load, cause local content is faster than downloading new content and local always wins, problem is DD-WRT is not a regular website and is undergoing work to the HTML lately, CSS is rarely touched now, so old cached files conflict with news ones.

Your only solution is to CTRL+F5 to force clear cache, this is well documented in the build threads when there are UI issues present, this is the goto action.

I can tell you it works now no matter browser used as long as cached content is cleared.

There are tricks I could have used, but where time is limited I opted to spend my time on more productive side, asking users to clear cache seems a fair exchange of effort.

dale_gribble39 wrote:
We would have to back-track to the first build that fixed flashing / upgrading the TL-WR901NDv2 (r47032/3) and check for this, if that is the case. Lead Developer Mr. Gottschall has been contacted about this issue already.


You can and it will still be there, I can say this with utmost confidence, the acid test is any other non usb port device and try a router database build, for my money it will still be a bug there. Literally no code Ive touched directly or indirectly has any effect on this. Guaranteed as evidence by the file history. This code is decades old.

Reading the Diagnostics.asp file, and because the double rendering of comments is to blame as shown on the devtools on both screenshots provided (<!--<!-- some code here-->-->) around the fieldset (double bubble on these is invalid btw) but we need the nvm call for devices with USB, so the fieldset shows with saved parameters. ill do a patch and see what the headmaster says

https://github.com/mirror/dd-wrt/pull/391.patch

In theory will fix it without breaking for usb devices. save to usb button is hidden so can never trigger the fieldset unless someone does some nvram set CLI bullshit.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
dale_gribble39
DD-WRT Guru


Joined: 11 Jun 2022
Posts: 752

PostPosted: Thu Sep 29, 2022 19:25    Post subject: Reply with quote
Well, the solution to the cosmetic page rendering issue was to create a special conditional compile rule for src/router/httpd/visuals/ejs.c, change the <% ifndef("USB", "-->"); %> tags, and remove the <% nvm("rc_usb", "", "<!--"); %> tags from src/router/kromo/dd-wrt/Diagnostics.asp rather than creating new base.nvramconfig, etc files for nousb firmware images or other conditional compilation mechanisms. Your patch didn't remove part of the underlying problem (the presence of rc_usb= nvram parameter). <wink>

https://svn.dd-wrt.com/changeset/50296
https://svn.dd-wrt.com/changeset/50297

We'll check for 50300 alpha later tonight 😎🎸🎶🤘💥

_________________
"The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep." - Robert Frost

"I am one of the noticeable ones - notice me" - Dale Frances McKenzie Bozzio

<fact>code knows no gender</fact>

This is me, knowing I've ruffled your feathers, and not giving a ****
Some people are still hard-headed.

--------------------------------------
Mac Pro (Mid 2012) - Two 2.4GHz 6-Core Intel Xeon E5645 processors 64GB 1333MHz DDR3 ECC SDRAM OpenSUSE Leap 15.4
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Thu Sep 29, 2022 19:50    Post subject: Reply with quote
My patch would have worked fine for 99% of users, except for really edge cases where users may import configs from other routers or manually set rc_usb variables via CLI.

What matters is that it is fixed in the end, even if the complainers protest too much no mater what happens.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)


Last edited by the-joker on Thu Sep 29, 2022 19:55; edited 1 time in total
egc
DD-WRT Guru


Joined: 18 Mar 2014
Posts: 10784
Location: Netherlands

PostPosted: Thu Sep 29, 2022 19:53    Post subject: Reply with quote
Thank you @dale_gribble39 for your solution.
_________________
Routers:Netgear R7800, R7000, R6400v1, R6400v2, Linksys EA8500, EA6900 (XvortexCFE), E2000, E1200v1, WRT54GS v1.
Install guide R6400v2, R6700v3,XR300:https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=316399
Install guide R7800/XR500: https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=320614
Forum Guide Lines (important read):https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=324087
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 2143
Location: All over YOUR webs

PostPosted: Thu Sep 29, 2022 19:58    Post subject: Reply with quote
egc wrote:
Thank you @dale_gribble39 for your solution.


You mean thank you brainslayer for the solution.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
Goto page Previous  1, 2, 3 ... 15, 16, 17 ... 19, 20, 21  Next Display posts from previous:    Page 16 of 21
Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum