UI themes! preview/public builds BUG hunting REPORTING

Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions
Goto page Previous  1, 2, 3 ... , 13, 14, 15  Next
Author Message
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 1579
Location: Germany

PostPosted: Thu Sep 15, 2022 11:49    Post subject: Reply with quote
best thanks

i do not know if your commit addresses all the problems

we have noticed the behavior with "Site Survey" "Channel Survey" and "Status Conntrack".

Link for reference: https://forum.dd-wrt.com/phpBB2/viewtopic.php?p=1271733#1271733
Sponsor
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 15, 2022 12:38    Post subject: Reply with quote
Its fixed, commit is away. I know what the issue is was on all sortable tables which I had thead. Shit happens it will be back to normal on next build.

Thx for the report. Cool

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
mrjcd
DD-WRT Guru


Joined: 31 Jan 2015
Posts: 5895
Location: Texas

PostPosted: Thu Sep 22, 2022 12:39    Post subject: Reply with quote
Mr. the-joker
GUI factory defaults --- click ok button does NOTHING...same message pops back up as shown in pic.
Using Chrome or FF.
I twas just goofin around to make a point but it NO worky but cmd line nvram erase && reboot did the job. Twisted Evil

ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 1579
Location: Germany

PostPosted: Thu Sep 22, 2022 13:04    Post subject: Reply with quote
@mrjcd

I just reset my R7800 via GUI (build r50176)
works as always
mrjcd
DD-WRT Guru


Joined: 31 Jan 2015
Posts: 5895
Location: Texas

PostPosted: Thu Sep 22, 2022 13:13    Post subject: Reply with quote
ho1Aetoo wrote:
@mrjcd

I just reset my R7800 via GUI (build r50176)
works as always

yea imma using r50218... pic shows ...although NOT a public release.
I know they have been doing lots changes & most likely know about this anyways.
I'm sure it will work on next public release. Cool
ho1Aetoo
DD-WRT Guru


Joined: 19 Feb 2019
Posts: 1579
Location: Germany

PostPosted: Thu Sep 22, 2022 14:39    Post subject: Reply with quote
oh sorry - I did not see
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 22, 2022 15:42    Post subject: Reply with quote
No changes done to this part nothing that would affect this,. Recent changes from previous public til 218 where formatting wise, classes wise some cleanup of unrelated html.

But ill have a look anyway,maybe I did and dont remember, good thing for git blame/history.

PS. here is what I've done recently. Starting with oldest to newest

https://github.com/mirror/dd-wrt/commit/f6d1cfca8087e4fa53d8111d16beaee73bd250eb#diff-be821c030b34e307c51ddee94e061d68077a57348be259f45ee25b091bb8fe87 @49848

https://github.com/mirror/dd-wrt/commit/5666db290387aae989b6e08e3f6290331f13fd98#diff-be821c030b34e307c51ddee94e061d68077a57348be259f45ee25b091bb8fe87 @49863

https://github.com/mirror/dd-wrt/commit/da66b5ce0b6701c8df41de11258270df3e6571d9#diff-be821c030b34e307c51ddee94e061d68077a57348be259f45ee25b091bb8fe87 this was @50165

after was just indenting stuffs https://github.com/mirror/dd-wrt/commit/8bda4c58715465a43325c3ae6f9b332cc5f3d8af#diff-be821c030b34e307c51ddee94e061d68077a57348be259f45ee25b091bb8fe87 @50198

and the most recent was https://github.com/mirror/dd-wrt/commit/128dc14998124a3797dbd44ac24b9067e68d4a78#diff-be821c030b34e307c51ddee94e061d68077a57348be259f45ee25b091bb8fe87 @50199 just adding classes to the footer buttons.

Nothing ever come close to the browser dialog boxes or anything that could affect it on this page, Ill continue looking but so far nothing is obvious.

To clarify this is the function that governs this

https://github.com/mirror/dd-wrt/blame/master/src/router/kromo/dd-wrt/Factory_Defaults.asp#L9-L18

That hasn't been touched in 15 years.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
mrjcd
DD-WRT Guru


Joined: 31 Jan 2015
Posts: 5895
Location: Texas

PostPosted: Thu Sep 22, 2022 16:19    Post subject: Reply with quote
Played with a bit more. Looky like OK & Cancel button are doing SAME:
https://mrjcd.com/junk/dd-wrt/EA8500/092222/simplescreenrecorder.mp4
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 22, 2022 16:22    Post subject: Reply with quote
Anything in dev console browser side when you're clicking the buttons?

I've asked for a test build for my router, since I been working on remote routers for features I dont have on mine, latest test builds weren't for my Asus so I cant test the latest code.

But dev console should have a clue.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 22, 2022 16:41    Post subject: Reply with quote
I think I found the culprit. Made no sense to me before but I see it could cause this, this apply button is used as a save button in another function called from the function governing this OK/Cancel, Ive made a revert and if it work, Ill need to make sure this will be better handled somehow.
_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
mrjcd
DD-WRT Guru


Joined: 31 Jan 2015
Posts: 5895
Location: Texas

PostPosted: Thu Sep 22, 2022 16:56    Post subject: Reply with quote
the-joker wrote:
But dev console should have a clue.



It does worky good with r50176 Smile
https://mrjcd.com/junk/dd-wrt/EA8500/092222/simplescreenrecorder-r50176.mp4

AND
nvram backup & restore work fine with r50218 ..takes me minutes but am back on it Twisted Evil
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 22, 2022 19:06    Post subject: Reply with quote
That's what I mentioned as found the culprit in my latest patch (still awaiting merge), as per my previous comment, so it should be fixed.

I have a way to make the apply button into an apply button not a mixed apply/save button as is currently.

Thanks for the report though, good catch, I should have been more thorough.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)


Last edited by the-joker on Thu Sep 22, 2022 19:17; edited 1 time in total
egc
DD-WRT Guru


Joined: 18 Mar 2014
Posts: 10347
Location: Netherlands

PostPosted: Thu Sep 22, 2022 19:13    Post subject: Reply with quote
You can always ask me for a build Smile

I have 50228 for your Asus Ac68u if you need one.

_________________
Routers:Netgear R7800, R7000, R6400v1, R6400v2, Linksys EA8500, EA6900 (XvortexCFE), E2000 (converted WRT320N), WRT54GS v1.
Install guide R6400v2, R6700v3,XR300:https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=316399
Install guide R7800/XR500: https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=320614
Forum Guide Lines (important read):https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=324087
the-joker
DD-WRT Developer/Maintainer


Joined: 31 Jul 2021
Posts: 1847
Location: All over YOUR webs

PostPosted: Thu Sep 22, 2022 19:18    Post subject: Reply with quote
@egc That build still has the introduced bug, patch with a bunch of fixes including this hasn't been merged yet.

Thanks for the offer though, I can wait another few hours. Ive alerted BS but hes busy with real life, so shrug.

_________________
Saving your retinas from the burn!🔥
DD-WRT Inspired themes for routers
DD-WRT Inspired themes for the phpBB Forum
DD-WRT Inspired themes for the SVN Trac & FTP site
Join in for a chat @ #style_it_themes_public:matrix.org or #style_it_themes:discord

DD-WRT UI Themes Bug Reporting and Discussion thread

Router: ANus RT-AC68U E1 (recognized as C1)
mrjcd
DD-WRT Guru


Joined: 31 Jan 2015
Posts: 5895
Location: Texas

PostPosted: Fri Sep 23, 2022 12:44    Post subject: Reply with quote
r50229 GUI set to factory defaults worky fine now Cool
thanky, Sir
Goto page Previous  1, 2, 3 ... , 13, 14, 15  Next Display posts from previous:    Page 14 of 15
Post new topic   Reply to topic    DD-WRT Forum Index -> General Questions All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum