[SOLVED] Fix for 6132 Stopping privoxy generates an error

Post new topic   Reply to topic    DD-WRT Forum Forum Index -> Contributions Upload
Author Message
yoyoma2
DD-WRT User


Joined: 24 Sep 2016
Posts: 113

PostPosted: Tue Oct 08, 2019 2:12    Post subject: [SOLVED] Fix for 6132 Stopping privoxy generates an error Reply with quote
As described in ticket 6132, stopping privoxy generates an error.

Code:
root@DD-WRT:~# stopservice privoxy
Bad argument `80'
Try `iptables -h' or 'iptables --help' for more information.

Since we check that variable privoxy_transp_exclude isn't empty before using it in start_privoxy in file privoxy.c, lets do the same in stop_privoxy.


Last edited by yoyoma2 on Mon Jan 06, 2020 0:30; edited 1 time in total
Sponsor
yoyoma2
DD-WRT User


Joined: 24 Sep 2016
Posts: 113

PostPosted: Sun Jan 05, 2020 6:23    Post subject: Reply with quote
An updated patch has been attached to ticket 6132. It has been tested in a std build so hopefully it can get submitted and the ticket resolved.
kernel-panic69
DD-WRT Guru


Joined: 08 May 2018
Posts: 3146
Location: Texas, USA

PostPosted: Sun Jan 05, 2020 19:25    Post subject: Reply with quote
He patched it differently, changed some of the code involved in https://svn.dd-wrt.com/changeset/41893
_________________
E4200 v1 DD-WRT 41954 mega (01/09/20) (K3.x)
R7000P DD-WRT 40270M kongac
E4200 v1 FreshTomato 2019.4
E4200 v1 FreshTomato 2020.1.development
R7000 FreshTomato 2020.1.development
E4200 v1 1.0.07.development
WRT3200ACM OpenWRT 18.06.5
---------------------------------------------------------
Linux User #377467 counter.li.org / linuxcounter.net
yoyoma2
DD-WRT User


Joined: 24 Sep 2016
Posts: 113

PostPosted: Mon Jan 06, 2020 0:29    Post subject: Reply with quote
Thanks for the update @kernel-panic69. Even better, he also optimized the calls to nvram_safe_get().

Thanks BS!
Display posts from previous:    Page 1 of 1
Post new topic   Reply to topic    DD-WRT Forum Forum Index -> Contributions Upload All times are GMT

Navigation

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum