[Chryses]

[Chryses]

Ok, so if I use udp inside the openvpn gui, when I configure pia, I'll use udp with your script, and the same for TCP, right?

Yep you right, I don't even though that was simple, write down informations then retrieve it!

[egc]

Just started working on it, very, very nice!

The validation and locking, impressive.

Will report later this weekend and will make a callback script for publishing ip and port number to DDNS

[egc]

I have made a callback script which updates my DDNS hostnames on NOIP.COM, one hostname with the external IP address and one hostname with the external port address (disguised as IP otherwise I can not upload it)

Tested if I could reach my VPN server from my phone with the retrieved IP and portnumber and BINGO success and working.

Have to polish the callback script and will make it available later.

One addition to the script:
in the usage maybe add the - option for internal = external port:

echo " --port PORT internal port of port forward (default=80), if internal port should be the same as external port use - "

@eibgrad your work is as always much valued and appreciated , thanks!

[egc]

Yes I have seen the script running, I will do the test and can always kill with the PID.

I have had the client run for several hours and it did not restart and everything keeps working, but I will test with killing the process maybe tomorow.

Sleep 20 is perhaps a little bit on the fast side I have made it sleep 40.

Furthermore, now I am nitpicking, your installation instructions, in the first step, are to enable JFFS2. I am personally not a big fan of using jffs2, once bricked a router when updating and jffs2 enabled, and although the script is not writing much to the flash ram, I am not comfortable with it so I use a USB stick with automount jffs.
Granted if you can not do that jffs2 is invaluable, but my first choice would be to use a USB stick, consider adding something like that in the installation instructions?

Will report back, so far, so good

[Chryses]

Here my transmission.callback

This callback script is intended to use with transmission installed on a device inside the intranet. Use an HTTP connection, so make sure that your router have access to the remote transmission-daemon

This callback do:
-> Save the port to a /tmp so can be taken from the remote machine
-> Try to set the pia port to the remote transmission

What you have to do?
You've to configure the remote url the username and the password.

The script:

[egc]

First draft of a working updater for NOIP.com
Will polish and check if update succeed, also have a retrieval script ready will publish later.
Updated with check for valid entriies

#!/bin/sh
#
# name: ddwrt-pia-port-forward.callback
# This must be used together with the PIA port forward scripts from @eibgrad:
# https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=313661&postdays=0&postorder=asc&start=30
# https://pastebin.com/P9nmpyxh
# version: 1.0.3, 10-jul-2019, by egc
# purpose: update hostnames of DDNS service from noip.com with external vpn ip address and opened up port number
#
# argument $1 : vpn public ip (0.0.0.0 if unknown)
# argument $2 : pia assigned external port (always 5 digit port number, 0 if unknown)
#
# place file in same directory as ddwrt-pia-port-forward.sh and make executable with:
# chmod +x /jffs/etc/config/ddwrt-pia-port-forward.callback
# modify the settings in the SETTINGS section, make sure not to use Windows style line endings

{
DEBUG= # uncomment/comment to enable/disable

logger "$(basename $0) executed, vpn_public_ip = $1"
logger "$(basename $0) executed, ext_port = $2"

[ ${DEBUG+x} ] && set -x

# ------------------------------- BEGIN SETTINGS -------------------------------- #
DDNS_USER="put in your user name"
DDNS_PASS="put in your password"
DDNS_HOST_IP="put in hostname of host for vpn public ip address"
DDNS_HOST_PN="put in hostname of host for vpn port number"
# ------------------------------- END SETTINGS -------------------------------- #

DDNS_USER_C="${DDNS_USER/@/%40}" # Replace @ with URL encoding %40 otherwise parse error with curl
vpn_public_ip=$1
ext_port=$2

#Disguise external port as IP number
EXT_PORT_IP="${ext_port:0:2}.${ext_port:2:1}.${ext_port:3:1}.${ext_port:4:1}"

# try curl, fallback to wget
which curl > /dev/null 2>&1 && GET_URL="curl -sLk https://" || GET_URL="wget -qO - http://"

[ $vpn_public_ip != "0.0.0.0" ] && \
$GET_URL"$DDNS_USER_C:$DDNS_PASS@dynupdate.no-ip.com/nic/update?hostname=$DDNS_HOST_IP&myip=${vpn_public_ip}" || \
logger "$(basename $0) No valid external IP, No update done"

[ $ext_port -ne 0 ] && \
$GET_URL"$DDNS_USER_C:$DDNS_PASS@dynupdate.no-ip.com/nic/update?hostname=$DDNS_HOST_PN&myip=${EXT_PORT_IP}" || \
logger "$(basename $0) No valid port address, No update done"

} 2>&1 | logger -t $(basename $0)[$$]

[egc]

Thanks will take a look tomorrow.

I have a new version of my call back script which is checking a valid IP address (0.0.0.0) and handle that.

But it is a clumsy if statement and I was looking for a more concise test option. I am slowly learning (ba)sh and admiring the [] && ||, the possibilities of the parameter expansion and the intricacies of regex

Long story short, I favor that the callback script will be passed two variables, the first the IP address, 0.0.0.0 when not valid and the second the 5 digit port address, 00000 when no port address can be obtained.

On a side note I have been trying to test:
kill -SIGUSR1 <process-id>
My VPN client is going down but does not reconnect at all I am stuck at TCP reconnecting.
Not sure what is going wrong, I am behind a residential gateway.
Will test it when I am home again but that is the end of July.

Have been using this setup for about 2 days, I have a watchdog because internet is crappy, in those two days the watch dog kicked in twice and your script and my callback script worked great got different port numbers on one occasion but that was updated correctly to my noip.com hostname.

So at the moment everything is working great

[Chryses]

Thanks for the update.
On my side I don't have any real check, the only check I can do is:
If the port is not a valid one (what I've to check? I know that have to be 5 digits long. What if a user chose a server that don't have a port-forwarding service? What number is returned? 0 or nothing?) I can skip the script execution and remove the pia file, then on remote device I can simply skip the port set-up inside transmission.

What do you think?

[egc]

I have updated my script with checks for 0.0.0.0 and 00000, could also perhaps send just 0 as invalid port number?

Edit:
Just checked your new script and you are returning a 0 if port can not be obtained. Excellent

Also did a quick test run with your new script and my own callback script updating my 2 hosts with noip.com with IP address and port number and that worked perfectly

Great job

[egc]

One thing I noticed, if I disable the OVPN client the script keeps running, not sure about the implications.

Problem is that DDWRT does not remove the openvpncl.pid when the OVPN client is disabled.

Alternatively maybe this works?:

[egc]

Thanks for the explanation, makes sense

[Chryses]

I also update both script, the local and remote one, in order to not set the port if some go wrong.

Btw, I just found a "problem". Like @eibgrad said, if a soft-reset or some happen, the port is "lose" because is not used and/or requested within 2 minutes. So, is some that is just happen to me, maybe not the same situation but ... see here, from html page from script:

[Chryses]

I'll try and let you know!

But what about a log? Is not possible to log the openvpn process with some code to add to Additional Config field and extract the ip from it? Like grep with regex and take only the last found, if different from the one that I used to know my vpn ip, request the port-forward

[Chryses]

I don't know if is correlated to the recent modification that I made: